Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cl/split out e2e tests #6242

Merged
merged 5 commits into from
May 7, 2024
Merged

fix: Cl/split out e2e tests #6242

merged 5 commits into from
May 7, 2024

Conversation

charlielye
Copy link
Contributor

@charlielye charlielye commented May 7, 2024

Give the e2e tests their own jobs and turn logging back on. They still just run as individual jest tests rather than previously when they all ran through compose.

Hopefully we can get more insights to any CI instability.

Copy link
Contributor

github-actions bot commented May 7, 2024

Changes to circuit sizes

Generated at commit: 81aacb390078ed21d4e4ecd764554a8fa70189d5, compared to commit: 0e828f3914078850b9a8e1e928c886c59cfab64e

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail_to_public +200 ❌ +0.06% -2 ✅ -0.00%
private_kernel_tail +200 ❌ +0.15% -7 ✅ -0.00%
public_kernel_tail -47 ✅ -0.01% -47 ✅ -0.00%
private_kernel_init -13 ✅ -0.01% -22 ✅ -0.01%
private_kernel_inner -23 ✅ -0.02% -37 ✅ -0.01%
public_kernel_app_logic -23 ✅ -0.03% -61 ✅ -0.02%
public_kernel_teardown -29 ✅ -0.04% -56 ✅ -0.02%
public_kernel_setup -29 ✅ -0.04% -56 ✅ -0.02%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_tail_to_public 349,078 (+200) +0.06% 1,536,194 (-2) -0.00%
private_kernel_tail 135,880 (+200) +0.15% 1,063,378 (-7) -0.00%
public_kernel_tail 382,050 (-47) -0.01% 1,379,932 (-47) -0.00%
private_kernel_init 91,742 (-13) -0.01% 285,730 (-22) -0.01%
private_kernel_inner 106,972 (-23) -0.02% 380,703 (-37) -0.01%
public_kernel_app_logic 86,970 (-23) -0.03% 382,778 (-61) -0.02%
public_kernel_teardown 71,926 (-29) -0.04% 301,994 (-56) -0.02%
public_kernel_setup 71,785 (-29) -0.04% 301,858 (-56) -0.02%

@charlielye charlielye requested a review from ludamad May 7, 2024 20:19
@charlielye charlielye marked this pull request as ready for review May 7, 2024 20:19
@charlielye charlielye enabled auto-merge (squash) May 7, 2024 21:21
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlielye charlielye merged commit 9750e70 into master May 7, 2024
94 checks passed
@charlielye charlielye deleted the cl/split_out_e2e_tests branch May 7, 2024 21:22
TomAFrench added a commit that referenced this pull request May 8, 2024
* master: (25 commits)
  fix: Enable client proof tests (#6249)
  chore: update cspell for abi demonomorphizer (#6258)
  feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: Pw/update merge check (#6201)
  chore(master): Release 0.37.1 (#6148)
  fix: Cl/split out e2e tests (#6242)
  feat: Typings generator with generics (#6235)
  chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226)
  chore: misc AVM migration prep changes (#6253)
  feat!: AES blackbox (#6016)
  chore(docs): Fix some typos in specs of private kernel initial (#6224)
  chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250)
  chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248)
  fix: registering PublicDataWitness in JsonRpcServer (#6243)
  feat: Sync from noir (#6234)
  feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants